[ElementTiming] Add element ID The element ID helps developers and analytics providers determine which element the PerformanceElementTiming entry is referring to. While we have other ways to find out the element for Image Element Timing (for\ example, we can use the image requested URL), for text the available resources will be much limited and thus ID is needed. Bug: 879270, 942033 Change-Id: I0f20609cf4edc7eb6431448c439b9cf911f89fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544948 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#646432} diff --git a/element-timing/image-with-rotation.html b/element-timing/image-with-rotation.html index 4e00c68..70b635e 100644 --- a/element-timing/image-with-rotation.html +++ b/element-timing/image-with-rotation.html
@@ -28,7 +28,7 @@ const index = window.location.href.lastIndexOf('/'); const pathname = window.location.href.substring(0, index - 14) + 'images/black-rectangle.png'; - checkElement(entry, pathname, 'rectangle', beforeRender); + checkElement(entry, pathname, 'rectangle', 'rect_id', beforeRender); checkNaturalSize(entry, 100, 50); const rect = entry.intersectionRect; // The div rotates with respect to the origin, so part of it will be invisible. @@ -44,7 +44,7 @@ observer.observe({entryTypes: ['element']}); }, 'Image intersectionRect is affected by rotation, but not its intrinsic size.'); </script> -<div class="my_div"> - <img src="/images/black-rectangle.png" elementtiming="rectangle"/> +<div class="my_div" id="div_id"> + <img src="/images/black-rectangle.png" elementtiming="rectangle" id="rect_id"/> </div> </body> 